Remove debugRenderPhaseSideEffects flag
#17270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two similar flags, `debugRenderPhaseSideEffects` and `debugRenderPhaseSideEffectsForStrictMode`. The strict mode one is the only one that is actually used. I think originally the theory is that we would one day turn it on for all components, even outside strict mode. But what we'll do instead is migrate everyone to strict mode. The only place `debugRenderPhaseSideEffects` was being used was in an internal test file. I rewrote those tests to use public APIs.
bvaughn
approved these changes
Nov 4, 2019
Size changes (experimental)ReactDOM: size: 0.0%, gzip: -0.0% Details of bundled changes.Comparing: 6dc2734...b3007a0 react-native-renderer
react-test-renderer
react-dom
react-art
react-reconciler
|
Size changes (stable)ReactDOM: size: 0.0%, gzip: -0.1% Details of bundled changes.Comparing: 6dc2734...b3007a0 react-dom
react-art
react-native-renderer
react-reconciler
|
acdlite
force-pushed
the
remove-feature-flag
branch
from
c1ad939 to
b3007a0
Compare
|
Should this callsite have been update too? Or is it different? https://github.com/facebook/react/blob/master/scripts/rollup/shims/react-native/ReactFeatureFlags.js It looks like there are still three callsites of |
aungkoman
pushed a commit
to ReactJSMyanmar/react
that referenced
this pull request
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two similar flags,
debugRenderPhaseSideEffectsanddebugRenderPhaseSideEffectsForStrictMode. The strict mode one is the only one that is actually used. I think originally the theory is that we would one day turn it on for all components, even outside strict mode. But what we'll do instead is migrate everyone to strict mode.The only place
debugRenderPhaseSideEffectswas being used was in an internal test file. I rewrote those tests to use public APIs.