Skip to content

Conversation

necolas
Copy link
Contributor

@necolas necolas commented Jan 22, 2020

Summary

Updates to Flow 0.97.

Flow made some changes when refining mixed to a function. But I don't understand how to fix our types to avoid this error, so I used $FlowFixMe to suppress them instead. Open to suggestions.

Test Plan

yarn flow dom

@necolas necolas requested a review from trueadm January 22, 2020 19:08
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jan 22, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 22, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 77f8a5e:

Sandbox Source
hidden-shape-ifsm3 Configuration

@sizebot
Copy link

sizebot commented Jan 22, 2020

Warnings
⚠️ Build job for base commit is still pending: 9d09052

Size changes (stable)

Generated by 🚫 dangerJS against 77f8a5e

@sizebot
Copy link

sizebot commented Jan 22, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 77f8a5e

@necolas necolas changed the title Update to flow 0.94 Update to flow 0.97 Jan 23, 2020
Copy link
Contributor

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shame about the FlowFixMes but we can come back to those later.

@necolas necolas merged commit 6faf6f5 into facebook:master Jan 24, 2020
@necolas necolas deleted the update-flow branch January 24, 2020 21:46
NMinhNguyen referenced this pull request in enzymejs/react-shallow-renderer Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants