Skip to content

[react-interactions] use dom-event-testing-library for Drag tests #17906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[react-interactions] use dom-event-testing-library for Drag tests #17906

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 20 additions & 42 deletions packages/react-interactions/events/src/dom/__tests__/Drag-test.internal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@

'use strict';

import {createEventTarget} from 'dom-event-testing-library';

let React;
let ReactFeatureFlags;
let ReactDOM;
Expand Down Expand Up @@ -77,9 +79,8 @@ describe('Drag event responder', () => {
}
divRef.current.dispatchEvent(mouseMoveEvent);

const mouseUpEvent = document.createEvent('MouseEvents');
mouseUpEvent.initEvent('mouseup', true, true);
divRef.current.dispatchEvent(mouseUpEvent);
const target = createEventTarget(divRef.current);
target.pointerup();

expect(events).toHaveLength(2);
expect(events).toEqual(
Expand Down Expand Up @@ -113,30 +114,17 @@ describe('Drag event responder', () => {

ReactDOM.render(<Component />, container);

const mouseOverEvent = document.createEvent('MouseEvents');
mouseOverEvent.initEvent('mousedown', true, true);
divRef.current.dispatchEvent(mouseOverEvent);
const target = createEventTarget(divRef.current);
target.pointerdown();

const mouseMoveEvent = document.createEvent('MouseEvents');
for (let index = 0; index <= 20; index++) {
mouseMoveEvent.initMouseEvent(
'mousemove',
true,
true,
window,
1,
index,
index,
50,
50,
);
divRef.current.dispatchEvent(mouseMoveEvent);
target.pointermove({
x: index,
y: index,
});
}
divRef.current.dispatchEvent(mouseMoveEvent);

const mouseUpEvent = document.createEvent('MouseEvents');
mouseUpEvent.initEvent('mouseup', true, true);
divRef.current.dispatchEvent(mouseUpEvent);
target.pointerup();

expect(events).toEqual(['dragstart', 'dragend']);
});
Expand Down Expand Up @@ -165,29 +153,19 @@ describe('Drag event responder', () => {

ReactDOM.render(<Component />, container);

const mouseOverEvent = document.createEvent('MouseEvents');
mouseOverEvent.initEvent('mousedown', true, true, window, 1, 0, 0);
divRef.current.dispatchEvent(mouseOverEvent);
const target = createEventTarget(divRef.current);

target.pointerdown();

const mouseMoveEvent = document.createEvent('MouseEvents');
for (let index = 0; index <= 20; index++) {
mouseMoveEvent.initMouseEvent(
'mousemove',
true,
true,
window,
1,
index + 1,
index + 1,
50,
50,
);
divRef.current.dispatchEvent(mouseMoveEvent);
target.pointermove({
x: index + 1,
y: index + 1,
});
}

const mouseUpEvent = document.createEvent('MouseEvents');
mouseUpEvent.initEvent('mouseup', true, true);
divRef.current.dispatchEvent(mouseUpEvent);
target.pointerup();

expect(events).toHaveLength(20);
expect(events).toEqual(
expect.arrayContaining([
Expand Down