Event not working when the react app is rendered inside the web component issue fix. #17991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @LevinsDurai! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a7fdeff:
|
Details of bundled changes.Comparing: df134d3...a7fdeff react-dom
Size changes (experimental) |
Details of bundled changes.Comparing: df134d3...a7fdeff react-dom
ReactDOM: size: 🔺+0.1%, gzip: 🔺+0.1% Size changes (stable) |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Here is the workable example app => https://oxbj4.csb.app/ |
|
The CI is failing, so looks like you might need to run prettier. Also please could you add a test case or at least a Fiddle where this change works compared to before? Thank you :) |
|
I’m really not sure about this solution. Please see the existing discussion in #12163. How does it address those concerns? |
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
|
Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Team,
Im levins and a big fan of react. I'm facing some css problem while using react in embeddable widget which can be embedded in websites and the same as chrome extension as well. We have often faced CSS overriding issue, hence I have opted to choose shadowDOM to sort this out. Since react events are binding globally, I have faced a problem in accessing react events inside shadowDOM. After digging react repo, I have figured out the getEventTarget() and added the supported changes.
This will be helpful for extending the support for ours and which uses shadowDOM or v8 engine based browsers.
Supported Browsers:
Almost all the Browsers using V8 engine. Even Edge was moving their browsers to V8 engine ( https://www.polymer-project.org/blog/2020-01-15-edge-79-release) .
)
Thanks and regards,
Levins.
Summary
Test Plan