Skip to content

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Feb 11, 2020

Reverts #18016

This change caused a Makehaste failure for syncs:

Cannot transform 'shared/react/ReactEventsFocus-dev.js': TypeError: Unsupported function type: ObjectMethod
...

The specific syntax change that causes the failure is going from this:

var Focus = (Object.freeze || Object)({
  passiveBrowserEventsSupported: passiveBrowserEventsSupported,

to this:

var Focus = Object.freeze({
  get passiveBrowserEventsSupported() {
    return passiveBrowserEventsSupported;
  },

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 11, 2020
@sizebot
Copy link

sizebot commented Feb 11, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against f0f60e6

@sizebot
Copy link

sizebot commented Feb 11, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against f0f60e6

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f0f60e6:

Sandbox Source
jovial-pike-x07zu Configuration

@bvaughn
Copy link
Contributor Author

bvaughn commented Feb 11, 2020

Closing in favor of #18022

@bvaughn bvaughn closed this Feb 11, 2020
@kassens kassens deleted the revert-18016-build-legacy-config branch November 29, 2022 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants