Revert "Fix email cursor jump (#18379)" #18459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9b88b78.
facebook-github-bot
added
CLA Signed
React Core Team
|
I'm going to leave the fixture tests though. Those are good to have and will guide future work. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a144fc3:
|
This was referenced Apr 1, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 9b88b78.
I've changed my mind. This is too scary to change because there are other unknowns around this whole area. Like we could be introducing more regressions like #17609. If we can't sit down and fix this holistically, the best we can do is to reduce changes to avoid churn in the workarounds.
Should we fix it eventually? Yes. With an approach that is well-thought out for all input types and doesn't cause other issues. Such as maybe disabling syncing would help here. We'll likely slate this for after 17.