Remove callbackId field from FiberRoot #19458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 71681be:
|
Details of bundled changes.Comparing: c24b641...71681be react-dom
react-native-renderer
react-reconciler
react-art
react-test-renderer
ReactDOM: size: 0.0%, gzip: -0.0% Size changes (stable) |
Details of bundled changes.Comparing: c24b641...71681be react-dom
react-reconciler
react-art
react-test-renderer
react-native-renderer
ReactDOM: size: 0.0%, gzip: -0.0% Size changes (experimental) |
rickhanlonii
approved these changes
Jul 27, 2020
| @@ -689,37 +689,32 @@ function ensureRootIsScheduled(root: FiberRoot, currentTime: number) { | |||
| markStarvedLanesAsExpired(root, currentTime); | |||
|
|
|||
| // Determine the next lanes to work on, and their priority. | |||
| const newCallbackId = getNextLanes( | |||
| const nextLanes = getNextLanes( | |||
There was a problem hiding this comment.
Looks like the comment on line 681 (which references the expiration time) is out of date, should we update that as well?
| @@ -741,7 +736,6 @@ function ensureRootIsScheduled(root: FiberRoot, currentTime: number) { | |||
| ); | |||
| } | |||
|
|
|||
| root.callbackId = newCallbackId; | |||
There was a problem hiding this comment.
We used to update the root callbackId with the next lane, why don't we need to do anything with the next lane in the new version?
There was a problem hiding this comment.
It was only used by this function. Since we don't need it for the logic above anymore, we don't have to store it.
The old expiration times implementation used this field to infer when the priority of a task had changed at a more granular level than a Scheduler priority level. Now that we have the LanePriority type, which is React-specific, we no longer need the `callbackId` field.
acdlite
force-pushed
the
remove-callbackid-field
branch
3 times, most recently
from
13518ec to
71681be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old expiration times implementation used this field to infer when the priority of a task had changed at a more granular level than a Scheduler priority level.
Now that we have the LanePriority type, which is React-specific, we no longer need the
callbackIdfield.