[Addons] Fix TransitionGroup null children bug #1958
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * Given `this.props.children`, return an object mapping key to child. Just | ||
| * simple syntactic sugar around ReactChildren.map(). | ||
| * Given `this.props.children`, return an object mapping key to child. `null` | ||
| * and `undefined` and stripped. |
|
(I approve making getChildMapping skip nulls, though I'm a little iffy on the test case…) |
Fixes facebook#1949 When we render two children to two nulls, `ReactTransitionChildMapping.getChildMapping` now returns `{}` rather than `{'.0': null, '.1': null}`. Otherwise mergeChildMapping doesn't doesn't understand that the children have disappeared.
|
The test case being iffy is because of another bug (#1959). That one is easy to fix but requires changing every test to async. I'll pull this in for now. |
|
@chenglou Do we still want this? |
|
This is over a year old, has a merge conflict, and I doubt @chenglou is going to be fixing it at this point. So... I'm going to close it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1949
When we render two children to two nulls,
ReactTransitionChildMapping.getChildMappingnow returns{}rather than{'.0': null, '.1': null}. Otherwise mergeChildMapping doesn't doesn't understand that the children have disappeared.