Provide a friendly path for reactID errors in ReactMount #1987
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dissected from my #1570
Provides a human friendly path instead of just a rather opaque reactID. Chrome still has intermittent issues with long error messages being truncated, but this is supposedly fixed (again) in Chrome 37. No other browsers should have issues displaying the full error message.
Now that we have friendlier error messages, how far do we want go to "resolve" implicitly added DOM? Personally I feel like we should get rid of the "blind jumps" we do now (primarily missing
thead
), it seems like unsafe behavior and it would be preferable for users to just be notified of the issue instead (technically, they provided invalid markup).(That error message is for nested
form
, which is invalid)