Update tutorial to include running Node server #2004
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tutorial suggests using python -m SimpleHTTPServer to serve content, but subsequently introduces a mechanism for submitting comments via a POST request, which SimpleHTTPServer doesn't support. It appears that at this point the tutorial assumes you're using the sample Node.js server packaged with the tutorial's GitHub repo but that isn't explained. This diff adds instructions on how to use the sample Node.js server. Fixes reactjs/react-tutorial#1
|
👍 |
|
I'm going to take #2824 instead but I really do appreciate you taking the time to work on this. I'm sorry we let it sit here for so long! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tutorial suggests using
python -m SimpleHTTPServerto serve content, but subsequently introduces a mechanism for submitting comments via a POST request, whichSimpleHTTPServerdoesn't support. It appears that at this point the tutorial assumes you're using the sample Node.js server packaged with the tutorial's GitHub repo but that isn't explained.This diff adds instructions on how to use the sample Node.js server.
Fixes reactjs/react-tutorial#1