Skip to content

[WIP] Bisect www sync failure #21201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 3, 2021
Merged

[WIP] Bisect www sync failure #21201

merged 6 commits into from
May 3, 2021

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Apr 8, 2021 •
edited
Loading

Using this draft PR to debug a hydration error

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 8, 2021
@sizebot
Copy link

sizebot commented Apr 8, 2021 •
edited
Loading

Comparing: 79740da...aea7c2a

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js +0.23% 122.49 kB 122.76 kB +0.10% 39.38 kB 39.42 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js +0.25% 129.02 kB 129.34 kB +0.13% 41.46 kB 41.51 kB
facebook-www/ReactDOM-prod.classic.js +0.16% 406.89 kB 407.53 kB +0.07% 75.31 kB 75.37 kB
facebook-www/ReactDOM-prod.modern.js +0.16% 394.75 kB 395.39 kB +0.16% 73.35 kB 73.46 kB
facebook-www/ReactDOMForked-prod.classic.js +0.16% 406.89 kB 407.53 kB +0.07% 75.31 kB 75.37 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-reconciler/cjs/react-reconciler.production.min.js +0.34% 86.45 kB 86.74 kB = 26.82 kB 26.81 kB
oss-stable/react-reconciler/cjs/react-reconciler.profiling.min.js +0.32% 89.53 kB 89.81 kB +0.01% 27.78 kB 27.78 kB
oss-experimental/react-reconciler/cjs/react-reconciler.production.min.js +0.32% 91.84 kB 92.13 kB = 28.47 kB 28.45 kB
oss-experimental/react-reconciler/cjs/react-reconciler.profiling.min.js +0.30% 96.91 kB 97.20 kB = 30.09 kB 30.09 kB
oss-experimental/react-dom/umd/react-dom.production.min.js +0.25% 128.97 kB 129.30 kB +0.17% 42.11 kB 42.18 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js +0.25% 129.02 kB 129.34 kB +0.13% 41.46 kB 41.51 kB
oss-experimental/react-dom/umd/react-dom.profiling.min.js +0.24% 134.01 kB 134.34 kB +0.19% 43.65 kB 43.73 kB
oss-experimental/react-dom/cjs/react-dom.profiling.min.js +0.24% 134.08 kB 134.41 kB +0.15% 43.03 kB 43.09 kB
oss-stable/react-dom/umd/react-dom.production.min.js +0.23% 122.48 kB 122.76 kB +0.15% 39.97 kB 40.03 kB
oss-stable/react-dom/cjs/react-dom.production.min.js +0.23% 122.49 kB 122.76 kB +0.10% 39.38 kB 39.42 kB
oss-stable/react-dom/umd/react-dom.profiling.min.js +0.22% 125.55 kB 125.83 kB +0.20% 40.91 kB 40.99 kB
oss-stable/react-dom/cjs/react-dom.profiling.min.js +0.22% 125.57 kB 125.84 kB +0.08% 40.37 kB 40.40 kB

Generated by 🚫 dangerJS against aea7c2a

@acdlite acdlite force-pushed the debug-hydration-error branch 5 times, most recently from 14453a7 to 1ad4e6c Compare April 11, 2021 02:07
@acdlite acdlite changed the title [WIP] Debug hydration error [WIP] Bisect www sync failure Apr 11, 2021
@acdlite acdlite force-pushed the debug-hydration-error branch 21 times, most recently from 25ab8d5 to f483bc2 Compare April 15, 2021 18:15
@acdlite acdlite force-pushed the debug-hydration-error branch 6 times, most recently from 3b702ed to d580a74 Compare April 19, 2021 05:36
@acdlite acdlite force-pushed the debug-hydration-error branch 4 times, most recently from 0c22392 to e700800 Compare April 28, 2021 16:50
@acdlite acdlite force-pushed the debug-hydration-error branch 2 times, most recently from 4221206 to fd907c1 Compare May 3, 2021 18:38
@acdlite acdlite merged commit aea7c2a into facebook:master May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acdlite @sizebot @facebook-github-bot