Improve and simplify findComponentRoot, do not optimistically traverse foreign nodes #2262
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on code from #1570
Supersedes #2261 (#2005 for why I think optimistic traversal of foreign nodes is bad).
Improved and simplified implementation of
findComponentRoot
. Makes less use of the "hacky"ReactInstanceHandles
. Once_parentComponent
makes it appearance, one way or another, the dependency onReactInstanceHandles
can be dropped entirely (which is very good).grunt test
and manual testing in our app