Skip to content

Conversation

salazarm
Copy link
Contributor

@salazarm salazarm commented Dec 8, 2021

Summary

Moving the client side behavior behind a feature flag

How did you test this change?

existing jest tests

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Dec 8, 2021
@sizebot
Copy link

sizebot commented Dec 8, 2021

Comparing: c7917fe...edb88ab

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 129.89 kB 129.73 kB = 41.62 kB 41.57 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 134.64 kB 134.48 kB = 43.00 kB 42.96 kB
facebook-www/ReactDOM-prod.classic.js = 428.08 kB 428.08 kB = 78.60 kB 78.60 kB
facebook-www/ReactDOM-prod.modern.js = 416.64 kB 416.64 kB = 76.91 kB 76.91 kB
facebook-www/ReactDOMForked-prod.classic.js = 428.08 kB 428.08 kB = 78.60 kB 78.60 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactDOMServer-prod.modern.js +0.54% 75.56 kB 75.96 kB +0.41% 16.17 kB 16.24 kB
facebook-www/ReactDOMServer-dev.modern.js +0.30% 228.69 kB 229.37 kB +0.19% 54.80 kB 54.90 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-profiling.js = 252.12 kB 251.62 kB = 45.88 kB 45.78 kB
oss-stable-semver/react-art/cjs/react-art.production.min.js = 81.96 kB 81.79 kB = 25.43 kB 25.40 kB
oss-stable/react-art/cjs/react-art.production.min.js = 81.96 kB 81.79 kB = 25.43 kB 25.40 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-prod.js = 237.02 kB 236.51 kB = 43.49 kB 43.39 kB

Generated by 🚫 dangerJS against edb88ab

@acdlite acdlite merged commit f2a59df into facebook:main Dec 8, 2021
facebook-github-bot pushed a commit to facebook/react-native that referenced this pull request Dec 14, 2021
Summary:
This sync includes the following changes:
- **[f2a59df48](facebook/react@f2a59df48 )**: Remove unstableAvoidThisFallback from OSS ([#22884](facebook/react#22884)) //<salazarm>//
- **[24dd07bd2](facebook/react@24dd07bd2 )**: Add custom element property support behind a flag ([#22184](facebook/react#22184)) //<Joey Arhar>//
- **[72e48b8e1](facebook/react@72e48b8e1 )**: Fix: Don't skip writing updated package.json //<Andrew Clark>//
- **[e39b2c899](facebook/react@e39b2c899 )**: Fix peer deps for use-sync-external-store //<Andrew Clark>//
- **[ec78b135f](facebook/react@ec78b135f )**: Don't override use-sync-external-store peerDeps ([#22882](facebook/react#22882)) //<Andrew Clark>//
- **[5041c37d2](facebook/react@5041c37d2 )**: Remove hydrate option from createRoot ([#22878](facebook/react#22878)) //<salazarm>//
- **[3f9480f0f](facebook/react@3f9480f0f )**: enable continuous replay flag ([#22863](facebook/react#22863)) //<salazarm>//
- **[4729ff6d1](facebook/react@4729ff6d1 )**: Implement identifierPrefix option for useId ([#22855](facebook/react#22855)) //<Andrew Clark>//
- **[ed00d2c3d](facebook/react@ed00d2c3d )**: Remove unused flag ([#22854](facebook/react#22854)) //<Dan Abramov>//
- **[0cc724c77](facebook/react@0cc724c77 )**: update ReactFlightWebpackPlugin to be compatiable with webpack v5 ([#22739](facebook/react#22739)) //<Michelle Chen>//
- **[4e6eec69b](facebook/react@4e6eec69b )**: fix: document can be `null`, not just `undefined` ([#22695](facebook/react#22695)) //<Simen Bekkhus>//

Changelog:
[General][Changed] - React Native sync for revisions c1220eb...a049aa0

jest_e2e[run_all_tests]

Reviewed By: rickhanlonii

Differential Revision: D33062386

fbshipit-source-id: 37e497947efad5696c251096da8a92ccdc6dcea7
@salazarm salazarm deleted the removeUnstableAvoidThisFallback branch February 10, 2022 14:27
zhengjitf pushed a commit to zhengjitf/react that referenced this pull request Apr 15, 2022
* avoidThisFallbackFlag

* avoidThisFallback flag

* missed a spot

* rm gating
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants