DevTools: Refactor Profiler supported status and UI #23157
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 20, 2022 13:51
React will call the DevTools profiling hooks unconditionally (for DEV and profiling builds) but DevTools will only log the data to the User Timing API when DevTools is profiling.
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: 505c15c...1d6352c Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
bvaughn
force-pushed
the
devtools-profiler-refactor-phase-4
branch
from
17969bd to
1c94a1c
Compare
added 7 commits
January 20, 2022 14:40
React will call the DevTools profiling hooks unconditionally (for DEV and profiling builds) but DevTools will only log the data to the User Timing API when DevTools is profiling.
1. Backend reports legacy profiling support and timeline profiling support separately to the frontend.
2. Store repots static and dynamic/per-root profiling capabilities separately now. (This was previously kind of a bug.)
3. Timeline and legacy profiler buttons ("import data" and "clear data") are now no longer tab specific.
bvaughn
force-pushed
the
devtools-profiler-refactor-phase-4
branch
from
1c94a1c to
301fe89
Compare
bvaughn
changed the title
This was accidentally deleted in the previous commit.
lunaruan
approved these changes
Jan 20, 2022
|
Thank you for the review! I'm going to squash all of these PRs and commits here: I'll based my next branch off of that :) |
|
Squashed into #23158 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #23141.
This PR makes a few incremental changes to the store and profiler UI:
This PR adds the following commits:
Related to #22529.
UI changes
Timeline: No data
Timeline: Not supported
Timeline: Not supported (Facebook internal build)
Note that this PR (in isolation) makes the Timeline profiler feature unusable. It will be part of a stack of PRs that will be merged together once finished.