Bring in jsfiddle integration script, add harmony #2433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (!tag || tag.textContent.indexOf('window.onload=function(){') !== -1) { | ||
| alert('Bad JSFiddle configuration, please fork the original React JSFiddle'); | ||
| } | ||
| tag.setAttribute('type', 'text/jsx;harmony=true'); |
There was a problem hiding this comment.
it's just ;harmony, not =true
There was a problem hiding this comment.
Nope, we made it strict in #1827.
zpao
added a commit
that referenced
this pull request
Oct 31, 2014
Bring in jsfiddle integration script, add harmony
zpao
added a commit
that referenced
this pull request
Oct 31, 2014
Bring in jsfiddle integration script, add harmony
zpao
added a commit
that referenced
this pull request
Oct 31, 2014
|
Should we just update the base fiddle to use http://facebook.github.io/react/js/jsfiddle-integration.js or should we update the fb.me url to point at that? |
This was referenced Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings in http://dragon.ak.fbcdn.net/hphotos-ak-prn1/851561_341095626017279_6573_n.js which is currently living at http://fb.me/react-js-fiddle-integration.js. We should just serve from GitHub for this so its easier to update. In fact we can skip the fb.me hop entirely and update the base fiddle to point at facebook.github.io/js/jsfiddle-integration.js
cc @vjeux