Handle Github rate-limiting response in download-experimental-build.js #24573
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When running the
download-experimental-build.js
, fetching thebuild-id
for the commit uses a Github API. The code currently assumes that failure is due to the commit not existing. I hit rate limiting (working over a VPN), but the error reported the commit could not be found formain
.This change surfaces the API error message should it not be a
404
, in which case the previous error message worked well:How did you test this change?
Ran the change while I was being rate limited:
Confirmed that I was actually being rate limited:
Ran the change when I wasn't being rate limited:
Ran the change on my local machine while I was being rate limited. Waited for the