Update Rollup and related plugins to their most recent versions #24916
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,15 @@ | ||
| 'use strict'; | ||
|
|
||
| const rollup = require('rollup'); | ||
| const babel = require('@rollup/plugin-babel').babel; | ||
| const closure = require('./plugins/closure-plugin'); | ||
| const commonjs = require('@rollup/plugin-commonjs'); | ||
| const flowRemoveTypes = require('flow-remove-types'); | ||
| const prettier = require('rollup-plugin-prettier'); | ||
| const replace = require('@rollup/plugin-replace'); | ||
| const stripBanner = require('rollup-plugin-strip-banner'); | ||
| const chalk = require('chalk'); | ||
| const resolve = require('@rollup/plugin-node-resolve').nodeResolve; | ||
| const fs = require('fs'); | ||
| const argv = require('minimist')(process.argv.slice(2)); | ||
| const Modules = require('./modules'); | ||
|
|
@@ -146,6 +146,7 @@ function getBabelConfig( | |
| configFile: false, | ||
| presets: [], | ||
| plugins: [...babelPlugins], | ||
| babelHelpers: 'bundled', | ||
|
There was a problem hiding this comment. Added as per advice in https://github.com/rollup/plugins/blob/master/packages/babel/CHANGELOG.md#500
|
||
| }; | ||
| if (isDevelopment) { | ||
| options.plugins.push( | ||
|
|
@@ -189,6 +190,7 @@ function getRollupOutputOptions( | |
| name: globalName, | ||
| sourcemap: false, | ||
| esModule: false, | ||
| exports: 'auto', | ||
| }; | ||
| } | ||
|
|
||
|
|
@@ -342,7 +344,7 @@ function getPlugins( | |
| forbidFBJSImports(), | ||
| // Use Node resolution mechanism. | ||
| resolve({ | ||
| // skip: externals, // TODO: options.skip was removed in @rollup/plugin-node-resolve 3.0.0 | ||
|
Comment on lines
-345
to
+347
There was a problem hiding this comment. TODO: Is there a different value we should be using here now in it's place? ( |
||
| }), | ||
| // Remove license headers from individual modules | ||
| stripBanner({ | ||
|
|
@@ -367,11 +369,14 @@ function getPlugins( | |
| }, | ||
| // Turn __DEV__ and process.env checks into constants. | ||
| replace({ | ||
| preventAssignment: true, | ||
| values: { | ||
| __DEV__: isProduction ? 'false' : 'true', | ||
| __PROFILE__: isProfiling || !isProduction ? 'true' : 'false', | ||
| __UMD__: isUMDBundle ? 'true' : 'false', | ||
| 'process.env.NODE_ENV': isProduction ? "'production'" : "'development'", | ||
| __EXPERIMENTAL__, | ||
| }, | ||
| }), | ||
| // The CommonJS plugin *only* exists to pull "art" into "react-art". | ||
| // I'm going to port "art" to ES modules to avoid this problem. | ||
|
|
@@ -566,6 +571,7 @@ async function createBundle(bundle, bundleType) { | |
| treeshake: { | ||
| moduleSideEffects: (id, external) => | ||
| !(external && pureExternalModules.includes(id)), | ||
| propertyReadSideEffects: false, | ||
| }, | ||
| external(id) { | ||
| const containsThisModule = pkg => id === pkg || id.startsWith(pkg + '/'); | ||
|
|
@@ -655,7 +661,7 @@ async function createBundle(bundle, bundleType) { | |
|
|
||
| function handleRollupWarning(warning) { | ||
| if (warning.code === 'UNUSED_EXTERNAL_IMPORT') { | ||
| const match = warning.message.match(/external module "([^"]+)"/); | ||
| if (!match || typeof match[1] !== 'string') { | ||
| throw new Error( | ||
| 'Could not parse a Rollup warning. ' + 'Fix this method.' | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.