Skip to content

Conversation

kassens
Copy link
Member

@kassens kassens commented Oct 4, 2022

Stack from ghstack (oldest at bottom):

The existential type * was deprecated and a codemod provided to replace it. Ran that and did some manual fixups:

node_modules/.bin/flow codemod replace-existentials --write .

The existential type `*` was deprecated and a codemod provided to replace it. Ran that and did some manual fixups:

```sh
node_modules/.bin/flow codemod replace-existentials --write .
```

[ghstack-poisoned]
@facebook-github-bot facebook-github-bot added the React Core Team Opened by a member of the React Core Team label Oct 4, 2022
kassens added a commit to kassens/react that referenced this pull request Oct 4, 2022
The existential type `*` was deprecated and a codemod provided to replace it. Ran that and did some manual fixups:

```sh
node_modules/.bin/flow codemod replace-existentials --write .
```

ghstack-source-id: 0d970f8
Pull Request resolved: facebook#25416
@sizebot
Copy link

sizebot commented Oct 4, 2022

Comparing: 3fd9bd8...4ba0662

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 135.46 kB 135.46 kB = 43.41 kB 43.41 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 147.72 kB 147.72 kB = 47.17 kB 47.17 kB
facebook-www/ReactDOM-prod.classic.js = 491.70 kB 491.70 kB = 87.49 kB 87.49 kB
facebook-www/ReactDOM-prod.modern.js = 477.00 kB 477.00 kB = 85.24 kB 85.24 kB
facebook-www/ReactDOMForked-prod.classic.js = 491.70 kB 491.70 kB = 87.49 kB 87.49 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 4ba0662

The existential type `*` was deprecated and a codemod provided to replace it. Ran that and did some manual fixups:

```sh
node_modules/.bin/flow codemod replace-existentials --write .
```

[ghstack-poisoned]
@kassens kassens merged commit 4ba0662 into gh/kassens/1/base Oct 4, 2022
kassens added a commit that referenced this pull request Oct 4, 2022
The existential type `*` was deprecated and a codemod provided to replace it. Ran that and did some manual fixups:

```sh
node_modules/.bin/flow codemod replace-existentials --write .
```

ghstack-source-id: 4c98b8d
Pull Request resolved: #25416
@kassens kassens deleted the gh/kassens/1/head branch October 4, 2022 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants