Skip to content

fix function type for flow #25965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2023
Merged

fix function type for flow #25965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-devtools-shell/src/perf-regression/apps/LargeSubtree.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ function generateArray(size) {

const arr = generateArray(50000);

export default function LargeSubtree() {
export default function LargeSubtree(): React.Node {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React.Node or React.ReactNode ?

Copy link
Contributor

@ymqy ymqy Jan 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React.Node, https://flow.org/en/docs/react/types/#toc-react-node

const [showList, setShowList] = React.useState(false);
const toggleList = () => {
const startTime = performance.now();
Expand Down
2 changes: 1 addition & 1 deletion packages/react-devtools-shell/src/perf-regression/apps/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import * as React from 'react';
import LargeSubtree from './LargeSubtree';

export default function Home() {
export default function Home(): React.Node {
return (
<div>
<LargeSubtree />
Expand Down