Test case for stack overflow in ReactFizzServer #25971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
kassens
approved these changes
Jan 10, 2023
Comment on lines
290
to
302
| function createNestedComponent(depth: number) { | ||
| if (depth <= 0) { | ||
| return function Leaf() { | ||
| return <AsyncText text="Shell" />; | ||
| }; | ||
| } | ||
| const NextComponent = createNestedComponent(depth - 1); | ||
| function Component() { | ||
| return <NextComponent />; | ||
| } | ||
| return Component; | ||
| } | ||
| const NestedComponent = createNestedComponent(1500); |
There was a problem hiding this comment.
I think you can just make this a single component. Your current implementation returns a different instance on every re-render even for the same depth which is maybe not ideal.
Suggested change
| function createNestedComponent(depth: number) { | |
| if (depth <= 0) { | |
| return function Leaf() { | |
| return <AsyncText text="Shell" />; | |
| }; | |
| } | |
| const NextComponent = createNestedComponent(depth - 1); | |
| function Component() { | |
| return <NextComponent />; | |
| } | |
| return Component; | |
| } | |
| const NestedComponent = createNestedComponent(1500); | |
| function NestedComponent({depth}: {depth: number}) { | |
| if (depth <= 0) { | |
| return null; | |
| } | |
| return <NestedComponent depth={depth - 1} />; | |
| } |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 11, 2023
SSR currently stack overflows when the component tree is extremely large DiffTrain build for [fb324fa](fb324fa) [View git log for this commit](https://github.com/facebook/react/commits/fb324faf8a3da08212bcc5ea9e3a084dbfa80dad)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.