remove flow check in electron app.js #26184
Merged
+4
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
kassens
approved these changes
Feb 16, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Feb 17, 2023
When we were upgrading flow in 6ddcbd4 we added `$FlowFixMe` for some parameters in this file. However, this file is not compiled at all, and the `:` syntax breaks the code. This PR removes the flow check in this file DiffTrain build for [1a49e2d](1a49e2d) [View git log for this commit](https://github.com/facebook/react/commits/1a49e2d833ed24b4d541fc70659a19821585e570)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we were upgrading flow in 6ddcbd4 we added
$FlowFixMefor some parameters in this file. However, this file is not compiled at all, and the:syntax breaks the code.This PR removes the flow check in this file