Skip to content

Sync from oss-experimental, not oss-stable #26401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 16, 2023
Merged

Sync from oss-experimental, not oss-stable #26401

merged 2 commits into from
Mar 16, 2023

Conversation

rickhanlonii
Copy link
Member

Overview

To test useEffectEvent, we need the experimental build of the lint plugin.

@rickhanlonii rickhanlonii requested a review from poteto March 15, 2023 22:46
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 15, 2023
@react-sizebot
Copy link

react-sizebot commented Mar 15, 2023 •
edited
Loading

Comparing: 47cf4e5...58ef82f

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 157.42 kB 157.42 kB = 50.15 kB 50.15 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 159.01 kB 159.01 kB = 50.66 kB 50.66 kB
facebook-www/ReactDOM-prod.classic.js = 541.95 kB 541.95 kB = 96.53 kB 96.53 kB
facebook-www/ReactDOM-prod.modern.js = 525.68 kB 525.68 kB = 94.09 kB 94.09 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 58ef82f

gaearon
gaearon reviewed Mar 15, 2023
View reviewed changes
packages/eslint-plugin-react-hooks/src/ExhaustiveDeps.js Outdated
@@ -1856,7 +1856,7 @@ function isAncestorNodeOf(a, b) {

function isUseEffectEventIdentifier(node) {
if (__EXPERIMENTAL__) {
return node.type === 'Identifier' && node.name === 'useEffectEvent';
return node.type === 'Identifier' && (node.name === 'useEffectEvent' || node.name === 'experimental_useEffectEvent') ;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this makes sense. It wouldn't be caught by Rules of Hooks etc anyway. I think what we'd want to do is re-export it internally without the prefix when trying it.

gaearon
gaearon approved these changes Mar 15, 2023
View reviewed changes
Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can get the CI green, sounds fine, but I think we need to revert the suffix change. We'll instead re-export it under a use* name or we'll alias it at the import site.

@rickhanlonii rickhanlonii merged commit 21f6dba into facebook:main Mar 16, 2023
@rickhanlonii rickhanlonii deleted the rh/oss-exp-lint branch March 16, 2023 01:01
github-actions bot pushed a commit that referenced this pull request Mar 16, 2023
@rickhanlonii
Sync from oss-experimental, not oss-stable (#26401)
976efdb 
## Overview

To test useEffectEvent, we need the experimental build of the lint
plugin.

DiffTrain build for [21f6dba](21f6dba)
@sammy-SC sammy-SC mentioned this pull request Apr 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaearon gaearon gaearon approved these changes

@josephsavona josephsavona josephsavona approved these changes

@poteto poteto Awaiting requested review from poteto

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rickhanlonii @react-sizebot @gaearon @josephsavona @facebook-github-bot