Skip to content

Add additional supported methods to event documentation #2664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2015

Conversation

jasonwebster
Copy link

isPropagationStopped and isDefaultPrevented methods do in fact exist on SyntheticEvent

I have indeed signed the CLA.

`isPropagationStopped` and `isDefaultPrevented` methods do in fact exist on `SyntheticEvent`
@jasonwebster
Copy link
Author

On Fri, Dec 5, 2014 at 9:51 AM, Sebastian Markbåge <[email protected]

wrote:
I'm not sure these should be officially supported since they're
non-standard. We could probably just change it to use returnValue etc. to
follow the standard API.

👍 Makes perfect sense.

@zpao
Copy link
Member

zpao commented Dec 10, 2014

Closing because it sounds like @sebmarkbage said no (but I don't have that message - something got weird with GitHub)

@sebmarkbage
Copy link
Collaborator

Actually I'm not sure about this. I think returnValue isn't a spec:ed standard so I guess these jQuery-inspired methods are about as standard as it gets...

@zpao
Copy link
Member

zpao commented Jul 28, 2015

It's been a few months but let's do it. They exist. We should document them.

zpao added a commit that referenced this pull request Jul 28, 2015
Add additional supported methods to event documentation
@zpao zpao merged commit b766c62 into facebook:master Jul 28, 2015
@jasonwebster jasonwebster deleted the patch-1 branch July 29, 2015 03:04
zpao added a commit that referenced this pull request Aug 12, 2015
Add additional supported methods to event documentation
(cherry picked from commit b766c62)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants