Skip to content

Clean up enableUseHook flag #26707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2023
Merged

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Apr 23, 2023

This has been statically enabled everywhere for months.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 23, 2023
@acdlite acdlite force-pushed the clean-up-use-hook branch from ea45af6 to df64caf Compare April 23, 2023 17:41
@react-sizebot
Copy link

react-sizebot commented Apr 23, 2023

Comparing: a21d147...134732f

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 163.95 kB 163.93 kB = 51.68 kB 51.67 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 168.29 kB 168.28 kB = 52.94 kB 52.93 kB
facebook-www/ReactDOM-prod.classic.js = 568.30 kB 568.19 kB = 100.65 kB 100.64 kB
facebook-www/ReactDOM-prod.modern.js = 552.03 kB 551.92 kB = 97.99 kB 97.97 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-debug-tools/cjs/react-debug-tools.production.min.js +1.36% 6.79 kB 6.88 kB +1.63% 2.51 kB 2.55 kB
oss-stable-semver/react-debug-tools/cjs/react-debug-tools.production.min.js +1.36% 6.79 kB 6.88 kB +1.63% 2.51 kB 2.55 kB
oss-stable/react-debug-tools/cjs/react-debug-tools.production.min.js +1.36% 6.79 kB 6.88 kB +1.63% 2.51 kB 2.55 kB
oss-experimental/react-debug-tools/cjs/react-debug-tools.development.js +0.81% 22.65 kB 22.83 kB +1.36% 6.04 kB 6.12 kB
oss-stable-semver/react-debug-tools/cjs/react-debug-tools.development.js +0.81% 22.65 kB 22.83 kB +1.36% 6.04 kB 6.12 kB
oss-stable/react-debug-tools/cjs/react-debug-tools.development.js +0.81% 22.65 kB 22.83 kB +1.36% 6.04 kB 6.12 kB

Generated by 🚫 dangerJS against 134732f

This has been statically enabled everywhere for months.
@acdlite acdlite force-pushed the clean-up-use-hook branch from df64caf to 134732f Compare April 23, 2023 17:53
@acdlite acdlite merged commit 7ce765e into facebook:main Apr 23, 2023
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
This has been statically enabled everywhere for months.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
This has been statically enabled everywhere for months.

DiffTrain build for commit 7ce765e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants