Include rootNode as arg to componentWillUnmount

[sophiebits]

Fixes #174.

[yungsters]

I'm fine with this, but I noticed that componentWillUpdate does not have this, either. I'll let @zpao or @jordwalke make the call here.

[sophiebits]

Didn't notice that; adding it to componentWillUpdate would make sense to me for symmetry.

[yungsters]

I agree.

[sophiebits]

Added componentWillUpdate – before we were passing the ReactReconcileTransaction but it wasn't documented anywhere; not sure if anyone in FB relies on that.

As I add all of these I'm becoming less convinced that it's a good idea to pass the root node at all… makes it harder to add arguments in the future if we ever wanted to.

[jordwalke]

I agree with @spicyj here - by passing the DOM node, we touch the DOM when we don't need to. It kind of contradicts the edict of React itself - touch the DOM the minimal amount of times.

The code mod to remove this support might be tough.

[chenglou]

Even though I opened the issue, I'll chime in here: it was kind short-sighted and it's better if the root isn't passed at all. I haven't done any huge components or projects using this yet, so for me and maybe a bunch of other devs out there it's just a matter of adding one line at the beginning of the lifecycle method to rectify this.

[zpao]

Nothing has happened here and nobody seems excited for what's needs to happen to make this work, so I'm going to make an executive decision and say we won't do this.