Updated docs examples/recommendations to use findDOMNode instead of getDOMNode #2802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code change was already merged here: #2646 This new pull request is for the docs update. |
|
Maybe add it to the Top-Level API doc as well? |
|
Yea, let's add the toplevel doc. |
| @@ -201,7 +201,7 @@ Use this as an opportunity to operate on the DOM when the component has been upd | |||
|
|
|||
| > Note: | |||
| > | |||
| > Prior to v0.9, the DOM node was passed in as the last argument. If you were using this, you can still access the DOM node by calling `this.getDOMNode()`. | |||
| > Prior to v0.9, the DOM node was passed in as the last argument. If you were using this, you can still access the DOM node by calling `React.findDOMNode(this)`. | |||
There was a problem hiding this comment.
Let's kill this note completely.
|
Alright, lets address the notes and add this to the top level API docs, then we can merge this. |
jimfb
force-pushed
the
findDOMNode-in-docs
branch
from
324ccb4 to
61d2cf5
Compare
|
@zpao good to go? |
| DOMElement findDOMNode(ReactComponent component) | ||
| ``` | ||
|
|
||
| Finds the native DOM element, if any, associated with the given ReactComponent. |
There was a problem hiding this comment.
Can you just copy the text from here? http://facebook.github.io/react/docs/component-api.html#getdomnode
Maybe worth adding a note there too saying that React.findDOMNode is preferred.
jimfb
force-pushed
the
findDOMNode-in-docs
branch
2 times, most recently
from
036c843 to
d157895
Compare
jimfb
force-pushed
the
findDOMNode-in-docs
branch
from
d157895 to
030fc75
Compare
|
@spicyj better? |
|
@JSFB shipit |
jimfb
added a commit
that referenced
this pull request
Mar 6, 2015
Updated docs examples/recommendations to use findDOMNode instead of getDOMNode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated docs examples/recommendations to use findDOMNode instead of getDOMNode