Fix controlled radio button behavior #281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| bNode.checked = true; | ||
| // This line doesn't check any React code, but this test will be useless | ||
| // (and confusing) if the test environment doesn't behave properly with | ||
| // radio buttons, so we'll double-check |
There was a problem hiding this comment.
Fun fact... this test fails when I pull it in because our test environment doesn't behave properly :(
zpao
added a commit
that referenced
this pull request
Sep 7, 2013
Fix controlled radio button behavior
bvaughn
pushed a commit
to bvaughn/react
that referenced
this pull request
Aug 13, 2019
…after-navigation [WIP] Don't erase profiler data on navigation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #242.
@yungsters