Skip to content

Remove RTR from ReactCreateRef-test #28386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Remove RTR from ReactCreateRef-test #28386

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 19 additions & 12 deletions packages/react/src/__tests__/ReactCreateRef-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,16 @@
'use strict';

let React;
let ReactTestRenderer;
let ReactDOM;
let ReactDOMClient;

describe('ReactCreateRef', () => {
beforeEach(() => {
jest.resetModules();

React = require('react');
ReactTestRenderer = require('react-test-renderer');
ReactDOM = require('react-dom');
ReactDOMClient = require('react-dom/client');
});

it('should warn in dev if an invalid ref object is provided', () => {
Expand All @@ -31,12 +33,15 @@ describe('ReactCreateRef', () => {
}
}

const root = ReactDOMClient.createRoot(document.createElement('div'));
expect(() =>
ReactTestRenderer.create(
<Wrapper>
<div ref={{}} />
</Wrapper>,
),
ReactDOM.flushSync(() => {
root.render(
<Wrapper>
<div ref={{}} />
</Wrapper>,
);
}),
).toErrorDev(
'Unexpected ref object provided for div. ' +
'Use either a ref-setter function or React.createRef().\n' +
Expand All @@ -45,11 +50,13 @@ describe('ReactCreateRef', () => {
);

expect(() =>
ReactTestRenderer.create(
<Wrapper>
<ExampleComponent ref={{}} />
</Wrapper>,
),
ReactDOM.flushSync(() => {
root.render(
<Wrapper>
<ExampleComponent ref={{}} />
</Wrapper>,
);
}),
).toErrorDev(
'Unexpected ref object provided for ExampleComponent. ' +
'Use either a ref-setter function or React.createRef().\n' +
Expand Down