Skip to content

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Feb 26, 2024

Feature: #24580

@eps1lon eps1lon requested a review from rickhanlonii February 26, 2024 18:25
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 26, 2024
@react-sizebot
Copy link

react-sizebot commented Feb 26, 2024

Comparing: 9ffe910...e46b1e8

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 176.83 kB 176.83 kB = 54.91 kB 54.91 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 173.55 kB 173.55 kB = 54.11 kB 54.11 kB
facebook-www/ReactDOM-prod.classic.js +0.11% 594.04 kB 594.67 kB +0.08% 104.37 kB 104.45 kB
facebook-www/ReactDOM-prod.modern.js +0.11% 577.30 kB 577.93 kB +0.06% 101.42 kB 101.48 kB
test_utils/ReactAllWarnings.js Deleted 66.87 kB 0.00 kB Deleted 16.36 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactServer-prod.modern.js +0.77% 16.54 kB 16.66 kB +0.69% 4.34 kB 4.37 kB
facebook-www/React-prod.modern.js +0.63% 20.29 kB 20.42 kB +0.59% 5.09 kB 5.12 kB
facebook-www/React-prod.classic.js +0.62% 20.58 kB 20.71 kB +0.60% 5.15 kB 5.18 kB
facebook-www/React-profiling.modern.js +0.61% 20.73 kB 20.85 kB +0.62% 5.16 kB 5.20 kB
facebook-www/React-profiling.classic.js +0.60% 21.01 kB 21.14 kB +0.65% 5.23 kB 5.27 kB
test_utils/ReactAllWarnings.js Deleted 66.87 kB 0.00 kB Deleted 16.36 kB 0.00 kB

Generated by 🚫 dangerJS against e46b1e8

@eps1lon eps1lon marked this pull request as ready for review February 26, 2024 18:29
@kassens
Copy link
Member

kassens commented Mar 6, 2024

Sorry messed up the rebase merge resolution.

@eps1lon eps1lon force-pushed the feat/bigint/render-gk branch from 5a3c2f3 to e46b1e8 Compare March 14, 2024 14:57
@eps1lon
Copy link
Collaborator Author

eps1lon commented Mar 14, 2024

@kassens It can now be landed cleanly. When you land it, would you take care of rolling it out at Meta?

@jackpope
Copy link
Member

This change landed in #28617

@eps1lon eps1lon closed this Mar 27, 2024
@eps1lon eps1lon deleted the feat/bigint/render-gk branch March 27, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team React 19
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants