Upgrade to Rollup 4 #28704
Closed
Upgrade to Rollup 4 #28704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
Looks like there are some issues with the node version used in CI |
Node.js v16 is long deprecated, seems like for v20 there's some more stuff to fix.
|
Okay, I guess more CI stuff needs to be upgraded first. Skipping this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was looking at the rollup script and while nothing else came out of those attempts, this at least upgrades to the latest version of Rollup.
Diffed the built output and the only difference I noticed was that some more comments are preserved now in dev builds.
Stack created with Sapling. Best reviewed with ReviewStack.