Skip to content

Conversation

kassens
Copy link
Member

@kassens kassens commented Apr 2, 2024

This enables linting against unused suppressions and removes the ones that were unused.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 2, 2024
@react-sizebot
Copy link

react-sizebot commented Apr 2, 2024

Comparing: 49a4887...454f6c8

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 497.93 kB 497.93 kB = 89.26 kB 89.26 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 502.75 kB 502.75 kB = 89.96 kB 89.96 kB
facebook-www/ReactDOM-prod.classic.js = 597.17 kB 597.17 kB = 105.33 kB 105.33 kB
facebook-www/ReactDOM-prod.modern.js = 571.52 kB 571.52 kB = 101.27 kB 101.27 kB
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js = 108.69 kB 107.79 kB = 24.39 kB 24.28 kB
oss-stable-rc/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js = 99.38 kB 98.55 kB = 21.85 kB 21.76 kB
oss-stable-semver/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js = 99.38 kB 98.55 kB = 21.85 kB 21.76 kB
oss-stable/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js = 99.38 kB 98.55 kB = 21.85 kB 21.76 kB
oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js = 77.66 kB 76.83 kB = 16.41 kB 16.33 kB
oss-stable-rc/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js = 76.93 kB 76.09 kB = 16.31 kB 16.22 kB
oss-stable-semver/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js = 76.93 kB 76.09 kB = 16.31 kB 16.22 kB
oss-stable/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js = 76.93 kB 76.09 kB = 16.31 kB 16.22 kB
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB

Generated by 🚫 dangerJS against 454f6c8

…ions

This enables linting against unused suppressions and removes the ones that were unused.
@kassens kassens force-pushed the eslint-upgrade-warn-unused-disable branch from 0086bf2 to 454f6c8 Compare June 21, 2024 16:03
Copy link

vercel bot commented Jun 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2024 4:08pm

Copy link
Member

@poteto poteto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@kassens kassens merged commit b565373 into facebook:main Jun 21, 2024
@kassens kassens deleted the eslint-upgrade-warn-unused-disable branch June 21, 2024 16:24
hoxyq added a commit that referenced this pull request Jul 3, 2024
## Summary

Full list of changes, mostly fixes:
* chore[react-devtools/renderer]: dont show strict mode warning for prod
renderer builds ([hoxyq](https://github.com/hoxyq) in
[#30158](#30158))
* chore[react-devtools/ui]: fix strict mode badge styles
([hoxyq](https://github.com/hoxyq) in
[#30159](#30159))
* fix[react-devtools]: restore original args when recording errors
([hoxyq](https://github.com/hoxyq) in
[#30091](#30091))
* Read constructor name more carefully
([LoganDark](https://github.com/LoganDark) in
[#29954](#29954))
* refactor[react-devtools/extensions]: dont debounce cleanup logic on
navigation ([hoxyq](https://github.com/hoxyq) in
[#30027](#30027))
* lint: enable reportUnusedDisableDirectives and remove unused
suppressions ([kassens](https://github.com/kassens) in
[#28721](#28721))
* fix[react-devtools/extensions]: propagate globals from env
([hoxyq](https://github.com/hoxyq) in
[#29963](#29963))
* refactor[react-devtools/tests]: use registered marks instead of
cleared in tests ([hoxyq](https://github.com/hoxyq) in
[#29929](#29929))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants