Remove "derequire" from minified bundles #2964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should help alleviate #1933 |
|
Wow, good call. Thanks! |
zpao
added a commit
that referenced
this pull request
Jan 28, 2015
Remove "derequire" from minified bundles
|
This should really improve |
|
@zpao The |
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The point of running "derequire" is to rename the
requirecalls to something else. Well, minifying already does this in its mangle step. You still need "derequire" for the non-minified bundles though 😞This reduces the run time of
grunt buildfrom ~52sec to ~36sec on my machine (~30% less time). I can also shave off an extra 2-3 seconds by updating derequire's outdatedesprima-fbandestraverse- I'll put in a PR for that in that project later./cc @zpao