Skip to content

Revert "Set disableLegacyMode to true for www" #29901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Conversation

kassens
Copy link
Member

@kassens kassens commented Jun 14, 2024

Reverts #29871

Just temporarily while we're investigating something.

@kassens kassens requested a review from jackpope June 14, 2024 19:20
Copy link

vercel bot commented Jun 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2024 7:22pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jun 14, 2024
@react-sizebot
Copy link

Comparing: 3154ec8...6ef1e22

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.66 kB 6.66 kB = 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 497.93 kB 497.93 kB = 89.26 kB 89.26 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.67 kB 6.67 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 502.75 kB 502.75 kB = 89.96 kB 89.96 kB
facebook-www/ReactDOM-prod.classic.js +2.42% 583.08 kB 597.17 kB +2.05% 103.21 kB 105.33 kB
facebook-www/ReactDOM-prod.modern.js = 571.52 kB 571.52 kB = 101.27 kB 101.27 kB
facebook-www/ReactDOM-dev.classic.js +2.57% 1,045.51 kB 1,072.34 kB +2.61% 175.44 kB 180.02 kB
facebook-www/ReactDOMTesting-dev.classic.js +2.53% 1,062.43 kB 1,089.26 kB +2.60% 179.32 kB 183.98 kB
facebook-www/ReactDOM-profiling.classic.js +2.40% 612.25 kB 626.93 kB +2.14% 107.45 kB 109.76 kB
facebook-www/ReactDOMTesting-prod.classic.js +2.36% 597.83 kB 611.91 kB +2.01% 106.89 kB 109.05 kB
facebook-www/ReactReconciler-dev.classic.js +2.11% 715.56 kB 730.64 kB +1.97% 114.40 kB 116.65 kB
facebook-www/ReactART-dev.classic.js +2.10% 635.74 kB 649.11 kB +1.68% 102.38 kB 104.10 kB
facebook-www/ReactART-prod.classic.js +2.02% 359.94 kB 367.22 kB +1.87% 60.95 kB 62.09 kB
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactDOM-dev.classic.js +2.57% 1,045.51 kB 1,072.34 kB +2.61% 175.44 kB 180.02 kB
facebook-www/ReactDOMTesting-dev.classic.js +2.53% 1,062.43 kB 1,089.26 kB +2.60% 179.32 kB 183.98 kB
facebook-www/ReactDOM-prod.classic.js +2.42% 583.08 kB 597.17 kB +2.05% 103.21 kB 105.33 kB
facebook-www/ReactDOM-profiling.classic.js +2.40% 612.25 kB 626.93 kB +2.14% 107.45 kB 109.76 kB
facebook-www/ReactDOMTesting-prod.classic.js +2.36% 597.83 kB 611.91 kB +2.01% 106.89 kB 109.05 kB
facebook-www/ReactReconciler-dev.classic.js +2.11% 715.56 kB 730.64 kB +1.97% 114.40 kB 116.65 kB
facebook-www/ReactART-dev.classic.js +2.10% 635.74 kB 649.11 kB +1.68% 102.38 kB 104.10 kB
facebook-www/ReactART-prod.classic.js +2.02% 359.94 kB 367.22 kB +1.87% 60.95 kB 62.09 kB
facebook-www/ReactReconciler-prod.classic.js +1.91% 449.78 kB 458.36 kB +1.82% 72.71 kB 74.03 kB
facebook-www/React-dev.classic.js +1.18% 72.82 kB 73.68 kB +0.82% 16.01 kB 16.14 kB
facebook-www/JSXDEVRuntime-dev.classic.js +0.39% 32.44 kB 32.57 kB +0.30% 7.59 kB 7.61 kB
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB

Generated by 🚫 dangerJS against 6ef1e22

@kassens kassens merged commit 88959fd into main Jun 14, 2024
43 of 44 checks passed
@kassens kassens deleted the revert-29871-pr29871 branch June 14, 2024 19:32
github-actions bot pushed a commit that referenced this pull request Jun 14, 2024
Reverts #29871

Just temporarily while we're investigating something.

DiffTrain build for [88959fd](88959fd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants