Skip to content

www: remove dynamic scheduler feature flag: enableProfiling #29996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2024
Merged

www: remove dynamic scheduler feature flag: enableProfiling #29996

merged 1 commit into from
Jun 21, 2024

Conversation

kassens
Copy link
Member

@kassens kassens commented Jun 20, 2024

I removed the wrong feature flag in #29995, this is the correct one to match D58682445.

@kassens
www: remove dynamic scheduler feature flag: enableProfiling
13849b7 
I removed the wrong feature flag in facebook#29995, this is the correct one to match D58682445.
@vercel Vercel
Copy link

vercel bot commented Jun 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 9:29pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jun 20, 2024
@react-sizebot
Copy link

Comparing: 6ab67c3...13849b7

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.66 kB 6.66 kB = 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 497.93 kB 497.93 kB = 89.26 kB 89.26 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.67 kB 6.67 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 502.75 kB 502.75 kB = 89.96 kB 89.96 kB
facebook-www/ReactDOM-prod.classic.js = 597.17 kB 597.17 kB = 105.33 kB 105.33 kB
facebook-www/ReactDOM-prod.modern.js = 571.52 kB 571.52 kB = 101.27 kB 101.27 kB
facebook-www/Scheduler-profiling.classic.js = 14.82 kB 11.28 kB = 3.46 kB 2.76 kB
facebook-www/Scheduler-profiling.modern.js = 14.82 kB 11.28 kB = 3.46 kB 2.76 kB
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/Scheduler-dev.classic.js = 16.56 kB 16.39 kB = 3.54 kB 3.48 kB
facebook-www/Scheduler-dev.modern.js = 16.56 kB 16.39 kB = 3.54 kB 3.48 kB
facebook-www/SchedulerMock-dev.classic.js = 17.89 kB 17.59 kB +0.52% 3.67 kB 3.69 kB
facebook-www/SchedulerMock-dev.modern.js = 17.89 kB 17.59 kB +0.52% 3.67 kB 3.69 kB
facebook-www/Scheduler-profiling.classic.js = 14.82 kB 11.28 kB = 3.46 kB 2.76 kB
facebook-www/Scheduler-profiling.modern.js = 14.82 kB 11.28 kB = 3.46 kB 2.76 kB
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB

Generated by 🚫 dangerJS against 13849b7

@kassens kassens merged commit 0b724e9 into facebook:main Jun 21, 2024
@kassens kassens deleted the pr29996 branch June 21, 2024 13:51
github-actions bot pushed a commit that referenced this pull request Jun 21, 2024
@kassens
www: remove dynamic scheduler feature flag: enableProfiling (#29996)
174a36c 
I removed the wrong feature flag in #29995, this is the correct one to
match D58682445.

DiffTrain build for [0b724e9](0b724e9)
@eps1lon eps1lon mentioned this pull request Jul 16, 2024
Closed
This was referenced Jul 25, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yungsters yungsters yungsters approved these changes

@josephsavona josephsavona Awaiting requested review from josephsavona

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kassens @react-sizebot @yungsters @facebook-github-bot