[compiler][patch] Fix jsx non-ascii regex pattern #30382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: 512b09b...f1f0aaf Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
mofeiZ
commented
Jul 18, 2024
| ## Error | ||
|
|
||
| ``` | ||
| Property arguments[0] of CallExpression expected node to be of a type ["Expression","SpreadElement","JSXNamespacedName","ArgumentPlaceholder"] but instead got "JSXExpressionContainer" |
There was a problem hiding this comment.
This error is not caught and handled by Forget as it occurs in babel-plugin-fbt. Going to go back to hack in a check in MemoizeFbtAndMacroOperandsInSameScope for now, but ideally we would have some type / annotation on Identifier instances to know which strings are fbt operands
EDIT: moved this fixture to #30386
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
mofeiZ
commented
Jul 18, 2024
| @@ -2206,7 +2206,7 @@ function codegenInstructionValue( | |||
| * https://en.wikipedia.org/wiki/List_of_Unicode_characters#Control_codes | |||
| */ | |||
| const STRING_REQUIRES_EXPR_CONTAINER_PATTERN = | |||
| /[\u{0000}-\u{001F}|\u{007F}|\u{0080}-\u{FFFF}]|"/u; | |||
| /[\u{0000}-\u{001F}\u{007F}\u{0080}-\u{FFFF}]|"/u; | |||
There was a problem hiding this comment.
Previously, we were matching | literals
There was a problem hiding this comment.
I can't recall why we needed to escape the u{..., does it work without them?
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
poteto
approved these changes
Jul 18, 2024
| @@ -2206,7 +2206,7 @@ function codegenInstructionValue( | |||
| * https://en.wikipedia.org/wiki/List_of_Unicode_characters#Control_codes | |||
| */ | |||
| const STRING_REQUIRES_EXPR_CONTAINER_PATTERN = | |||
| /[\u{0000}-\u{001F}|\u{007F}|\u{0080}-\u{FFFF}]|"/u; | |||
| /[\u{0000}-\u{001F}\u{007F}\u{0080}-\u{FFFF}]|"/u; | |||
There was a problem hiding this comment.
I can't recall why we needed to escape the u{..., does it work without them?
felixshiftellecon
added a commit
to felixshiftellecon/react
that referenced
this pull request
Jul 24, 2024
ghstack-source-id: 97ed491 Pull Request resolved: facebook#30382
felixshiftellecon
added a commit
to felixshiftellecon/react
that referenced
this pull request
Jul 24, 2024
ghstack-source-id: 97ed491 Pull Request resolved: facebook#30382
This was referenced Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):