Skip to content

[ci] Add devtools regression workflow #30406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 25, 2024
Merged

[ci] Add devtools regression workflow #30406

merged 11 commits into from
Jul 25, 2024

Conversation

poteto
Copy link
Member

@poteto poteto commented Jul 19, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

More or less a straight copy from the circleci config. I spotted some
inefficiencies but will fix those later to make reviewing this easier.

@poteto
Update
109b775 
[ghstack-poisoned]
@vercel Vercel
Copy link

vercel bot commented Jul 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2024 9:17pm

poteto added a commit that referenced this pull request Jul 19, 2024
@poteto
[ci] Add devtools regression workflow
7ca5997 
More or less a straight copy from the circleci config. I spotted some
inefficiencies but will fix those later to make reviewing this easier.

ghstack-source-id: c60f15f
Pull Request resolved: #30406
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jul 19, 2024
@react-sizebot
Copy link

react-sizebot commented Jul 19, 2024 •
edited
Loading

Comparing: 0a76aec...9a7d2f4

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 501.39 kB 501.39 kB = 89.96 kB 89.96 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 506.21 kB 506.21 kB = 90.66 kB 90.66 kB
facebook-www/ReactDOM-prod.classic.js = 598.83 kB 598.83 kB = 105.76 kB 105.76 kB
facebook-www/ReactDOM-prod.modern.js = 574.94 kB 574.94 kB = 101.99 kB 101.99 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 97bc220

@poteto
Update
454864f 
[ghstack-poisoned]
poteto added a commit that referenced this pull request Jul 19, 2024
@poteto
[ci] Add devtools regression workflow
efb1314 
More or less a straight copy from the circleci config. I spotted some
inefficiencies but will fix those later to make reviewing this easier.

ghstack-source-id: e76d824
Pull Request resolved: #30406
@poteto
Update
d8b35d1 
[ghstack-poisoned]
poteto added a commit that referenced this pull request Jul 19, 2024
@poteto
[ci] Add devtools regression workflow
e98a9a4 
More or less a straight copy from the circleci config. I spotted some
inefficiencies but will fix those later to make reviewing this easier.

ghstack-source-id: d33946f
Pull Request resolved: #30406
@hoxyq
Copy link
Contributor

hoxyq commented Jul 19, 2024

I have no idea why e2e tests are failing for React 16, because they were passing on main yesterday and there were no changes to React / React DevTools since then. Maybe there is something related to the environment, is the version of Node the same?

@poteto
Update
c4e0985 
[ghstack-poisoned]
poteto added a commit that referenced this pull request Jul 19, 2024
@poteto
[ci] Add devtools regression workflow
4ee7341 
More or less a straight copy from the circleci config. I spotted some
inefficiencies but will fix those later to make reviewing this easier.

ghstack-source-id: 90332d0
Pull Request resolved: #30406
@poteto
Update
81c8429 
[ghstack-poisoned]
poteto added a commit that referenced this pull request Jul 22, 2024
@poteto
[ci] Add devtools regression workflow
375ec09 
More or less a straight copy from the circleci config. I spotted some
inefficiencies but will fix those later to make reviewing this easier.

ghstack-source-id: 811e30d
Pull Request resolved: #30406
@poteto
Update
1049cbb 
[ghstack-poisoned]
poteto added a commit that referenced this pull request Jul 22, 2024
@poteto
[ci] Add devtools regression workflow
c9536b1 
More or less a straight copy from the circleci config. I spotted some
inefficiencies but will fix those later to make reviewing this easier.

ghstack-source-id: 2e9b440
Pull Request resolved: #30406
@poteto
Update
e9528de 
[ghstack-poisoned]
poteto added a commit that referenced this pull request Jul 22, 2024
@poteto
[ci] Add devtools regression workflow
62e08b5 
More or less a straight copy from the circleci config. I spotted some
inefficiencies but will fix those later to make reviewing this easier.

ghstack-source-id: 2bf2e60
Pull Request resolved: #30406
@poteto
Update
1f09755 
[ghstack-poisoned]
poteto added a commit that referenced this pull request Jul 22, 2024
@poteto
[ci] Add devtools regression workflow
9fdb86b 
More or less a straight copy from the circleci config. I spotted some
inefficiencies but will fix those later to make reviewing this easier.

ghstack-source-id: 811e30d
Pull Request resolved: #30406
@poteto
Update
8b5e301 
[ghstack-poisoned]
poteto added a commit that referenced this pull request Jul 25, 2024
@poteto
[ci] Add devtools regression workflow
ec35330 
More or less a straight copy from the circleci config. I spotted some
inefficiencies but will fix those later to make reviewing this easier.

ghstack-source-id: 5e3c190
Pull Request resolved: #30406
@poteto
Update
076fd2a 
[ghstack-poisoned]
poteto added a commit that referenced this pull request Jul 25, 2024
@poteto
[ci] Add devtools regression workflow
f4ef27d 
More or less a straight copy from the circleci config. I spotted some
inefficiencies but will fix those later to make reviewing this easier.

ghstack-source-id: 32fcfdc
Pull Request resolved: #30406
@poteto
remove building on PRs
97bc220 
[ghstack-poisoned]
poteto added a commit that referenced this pull request Jul 25, 2024
@poteto
[ci] Add devtools regression workflow
72e974c 
More or less a straight copy from the circleci config. I spotted some
inefficiencies but will fix those later to make reviewing this easier.

ghstack-source-id: cb3456c
Pull Request resolved: #30406
@poteto
Copy link
Member Author

poteto commented Jul 25, 2024

Fixed: https://github.com/facebook/react/actions/runs/10101504603

@poteto poteto mentioned this pull request Jul 25, 2024
Merged
@poteto poteto requested a review from hoxyq July 25, 2024 21:25
@poteto poteto merged commit 97bc220 into gh/poteto/34/base Jul 25, 2024
190 checks passed
poteto added a commit that referenced this pull request Jul 25, 2024
@poteto
[ci] Add devtools regression workflow
fe225e3 
More or less a straight copy from the circleci config. I spotted some
inefficiencies but will fix those later to make reviewing this easier.

ghstack-source-id: cb3456c
Pull Request resolved: #30406
@poteto poteto deleted the gh/poteto/34/head branch July 25, 2024 21:27
@eps1lon eps1lon mentioned this pull request Jul 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoxyq hoxyq Awaiting requested review from hoxyq

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@poteto @react-sizebot @hoxyq @facebook-github-bot