Failing test for pass-through error boundary and faulty renders triggered by Effects #30574
+44
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: 06d0b89...a5a8cf7 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
|
This is not actually a bug in a way. It's expected behavior. It's considered an infinite loop to render original children from an error boundary since it'll just render the same thing again. Like we can't forever just treat any new error that happens as if it's a rethrow after having recovered once. |
|
Then we have a bug when we throw during the initial render since that doesn't infinitely render. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by working in vercel/next.js#67861
When you throw an error during a render that was triggered from an Effect, React should treat that the same as if it would've happened during the initial render. However, when you have an error boundary that just passes the error through by returning children like nothing happened (like rethrowing but for error boundaries), React will retry the error infinitely.
React should just stop after a retry like it normally does.
In our tests we hit the "maximum update-depth exceeded" but in Codesandbox and Next.js it just renders infinitely.