Skip to content

Allow editing of TODOs in examples/todomvc #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Allow editing of TODOs in examples/todomvc #306

wants to merge 1 commit into from

Conversation

steveluscher
Copy link
Contributor

Until #219 is complete, this enable editing of TODOs in the TodoMVC example.

Until #219 is complete, this enable editing of TODOs in the TodoMVC example.
@chenglou
Copy link
Contributor

Ah this… @zpao? I have the completely revamped Todo from TodoMVC (passes all manual inspection), complete with integration with Director router. I suggest to remove the two todos (vanilla and backbone integration) in favor of that one, but removing backbone might be a bit too strong.

@petehunt
Copy link
Contributor

Why don't we start by removing the vanilla one so our checkin and tastejs are in sync.

Sent from my iPhone

On Aug 31, 2013, at 1:32 PM, "Cheng Lou" <[email protected]mailto:[email protected]> wrote:

Ah this… @zpaohttps://urldefense.proofpoint.com/v1/url?u=https://github.com/zpao&k=ZVNjlDMF0FElm4dQtryO4A%3D%3D%0A&r=qYx6qLphxKhA5vHBqr9vuw%3D%3D%0A&m=bllx%2F4smiFRhmr2253J5p7AypU8G2dS3diartAobvGs%3D%0A&s=59eb10bd55d264de94df91e3f7c44801d3ea93aa2befe5af424f291d78c815b7? I have the completely revamped Todo from TodoMVC (passes all manual inspection), complete with integration with Director router. I suggest to remove the two todos (vanilla and backbone integration) in favor of that one, but removing backbone might be a bit too strong.


Reply to this email directly or view it on GitHubhttps://urldefense.proofpoint.com/v1/url?u=#306.

@chenglou
Copy link
Contributor

Sure. Sorry about that, somehow I completely neglected this after I finished it.

@petehunt
Copy link
Contributor

All good, I should have pulled it in. Thanks for doing it :)

@chenglou
Copy link
Contributor

chenglou commented Sep 1, 2013

#307

@zpao
Copy link
Member

zpao commented Sep 6, 2013

Hey @steveluscher, thanks for poking this and kicking @chenglou's butt into action :) I'm going to close this out BUT if we do a 0.4.2 (#299), I'll come back and grab this too.

@zpao zpao closed this Sep 6, 2013
@steveluscher steveluscher deleted the patch-1 branch February 16, 2015 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants