[compiler] Fixture to show current behavior of nested function declarations #30921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ations Summary: Shows both memoized and unmemoized function declarations [ghstack-poisoned]
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
josephsavona
approved these changes
Sep 9, 2024
Comment on lines
+11
to
+13
| function h(x) { | ||
| return 2; | ||
| } |
There was a problem hiding this comment.
are we intentionally not using x? maybe add a comment with why not
|
The idea here was to document the changes in the way we emit function declarations after the next diff... which in retrospect, I muddled by modifying the example in that diff to include additional function calls :| |
|
Actually not really a useful test case at all, looking more at it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
Shows both memoized and unmemoized function declarations