Skip to content

Fix prepare-prerelease script #31159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 10, 2024
Merged

Fix prepare-prerelease script #31159

merged 3 commits into from
Oct 10, 2024

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Oct 9, 2024

Summary

Batch of fixes to allow publishing eslint-plugin-react-hooks. Each commit fixes a different bug.

How did you test this change?

$ scripts/release/prepare-release-from-npm.js --version=5.1.0-rc-ed966dac-20241007 --skipTests --skipPackages react react-dom react-server-dom-webpack react-server-dom-turbopack react-is react-reconciler react-refresh react-test-renderer use-subscription use-sync-external-store scheduler jest-react react-art

✓ Checking out "next" from NPM 5.1.0-rc-ed966dac-20241007 582 ms
✓ Guessing stable version numbers 381 ms
✓ Version for eslint-plugin-react-hooks (default 4.6.3): 5.0.0

A stable release candidate has been prepared!

You can review the contents of this release in build/node_modules/

Before publishing, consider testing this release locally with create-react-app!

You can publish this release by running:
  scripts/release/publish.js

@vercel Vercel
Copy link

vercel bot commented Oct 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 4:40pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Oct 9, 2024
@react-sizebot
Copy link

react-sizebot commented Oct 9, 2024 •
edited
Loading

The size diff is too large to display in a single comment. The GitHub action for this pull request contains an artifact called 'sizebot-message.md' with the full message.

Generated by 🚫 dangerJS against 7a57e4b

@eps1lon eps1lon force-pushed the sebbie/fix-prerelease branch from 480b2d0 to 7a57e4b Compare October 9, 2024 16:38
@eps1lon eps1lon marked this pull request as ready for review October 9, 2024 16:39
eps1lon
eps1lon commented Oct 9, 2024
View reviewed changes
scripts/release/prepare-release-from-npm.js
Comment on lines +30 to +32
params.packages = params.packages.filter(packageName => {
return !params.skipPackages.includes(packageName);
});
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were assuming that --version matches the version of every public package which isn't true.

@eps1lon eps1lon requested a review from poteto October 9, 2024 16:46
@eps1lon eps1lon merged commit 16ac71a into facebook:main Oct 10, 2024
184 checks passed
@eps1lon eps1lon deleted the sebbie/fix-prerelease branch October 10, 2024 15:24
This was referenced Oct 10, 2024
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poteto poteto poteto approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eps1lon @react-sizebot @poteto @facebook-github-bot