[compiler][ez] Clean up pragma parsing for tests + playground #31347
+101
−114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
josephsavona
reviewed
Nov 5, 2024
| /** | ||
| * For snap test fixtures and playground only. | ||
| */ | ||
| export function parseConfigPragma(pragma: string): EnvironmentConfig { |
There was a problem hiding this comment.
Before this just used environment defaults, now we're explicitly adding in dummy values just for tests/playground. Let's rename? parseConfigPragmaForTests() or similar
josephsavona
approved these changes
Nov 5, 2024
Move environment config parsing for `inlineJsxTransform`, `lowerContextAccess`, and some dev-only options out of snap (test fixture). These should now be available for playground via `@inlineJsxTransform` and `lowerContextAccess`. Other small change: Changed zod fields from `nullish()` -> `nullable().default(null)`. [`nullish`](https://zod.dev/?id=nullish) fields accept `null | undefined` and default to `undefined`. We don't distinguish between null and undefined for any of these options, so let's only accept null + default to null. This also makes EnvironmentConfig in the playground more accurate. Previously, some fields just didn't show up as `prettyFormat({field: undefined})` does not print `field`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move environment config parsing for
inlineJsxTransform,lowerContextAccess, and some dev-only options out of snap (test fixture). These should now be available for playground via@inlineJsxTransformandlowerContextAccess.Other small change:
Changed zod fields from
nullish()->nullable().default(null).nullishfields acceptnull | undefinedand default toundefined. We don't distinguish between null and undefined for any of these options, so let's only accept null + default to null. This also makes EnvironmentConfig in the playground more accurate. Previously, some fields just didn't show up asprettyFormat({field: undefined})does not printfield.See playground:
Before (note environment options missing)
After (note environment options not missing)
@inlineJsxTransformand a few others now also work