Skip to content

Conversation

kassens
Copy link
Member

@kassens kassens commented Nov 5, 2024

No description provided.

Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 7:03pm

@react-sizebot
Copy link

The size diff is too large to display in a single comment. The GitHub action for this pull request contains an artifact called 'sizebot-message.md' with the full message.

Generated by 🚫 dangerJS against 478a6f1

@kassens kassens merged commit 6c0f37f into facebook:main Nov 5, 2024
184 checks passed
@kassens kassens deleted the pr31429 branch November 5, 2024 20:49
kassens added a commit to kassens/react that referenced this pull request Nov 6, 2024
…)"

Backs out the 2 related commits:
- facebook@f8f6e1a
- facebook@6c0f37f

Since I only realized when syncing that we need the version of `react` and the legacy renderer to match.

While I investigate if there's anything we can do to work around that while preserving the legacy renderer, this unblocks the sync.
kassens added a commit that referenced this pull request Nov 6, 2024
…1437)

Backs out the 2 related commits:
-
f8f6e1a
-
6c0f37f

Since I only realized when syncing that we need the version of `react`
and the legacy renderer to match.

While I investigate if there's anything we can do to work around that
while preserving the legacy renderer, this unblocks the sync.
github-actions bot pushed a commit that referenced this pull request Nov 6, 2024
…1437)

Backs out the 2 related commits:
-
f8f6e1a
-
6c0f37f

Since I only realized when syncing that we need the version of `react`
and the legacy renderer to match.

While I investigate if there's anything we can do to work around that
while preserving the legacy renderer, this unblocks the sync.

DiffTrain build for [3149685](3149685)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants