[compiler] Implement support for non-declaration for initializers #31712
Conversation
[ghstack-poisoned]
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…alizers" [ghstack-poisoned]
| for (42; i < 1; i += 1) {} | ||
| for (bar(); i < 1; i += 1) {} | ||
| for (; i < 1; i += 1) {} | ||
| for (i = 0; i < 1; i += 1) {} |
There was a problem hiding this comment.
let's test a more complex initializer value, like a logical expression, ternary, sequence expression, or optional.
| @@ -1354,6 +1354,8 @@ function codegenForInit( | |||
| init: ReactiveValue, | |||
| ): t.Expression | t.VariableDeclaration | null { | |||
| if (init.kind === 'SequenceExpression') { | |||
| // We may end up emitti | |||
| * emit as an expression instead | ||
| */ | ||
| cx.temp = temp; | ||
| return codegenInstructionValueToExpression(cx, init); |
There was a problem hiding this comment.
could this skip over remaining instructions? since it's exiting the loop and function
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
github-actions
bot
added
the
Resolution: Stale
ghstack-source-id: 894914a Pull Request resolved: facebook/react#31712
|
Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you! |
Stack from ghstack (oldest at bottom):