-
Notifications
You must be signed in to change notification settings - Fork 49.3k
Add ref to Fragment (alternative) #32465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
416914f
Add enableFragmentRefs feature flag
jackpope 415795e
Create and attach fragment instances
jackpope d305203
Remove public append/remove child APIs
jackpope 4ff4ec3
Handle children with multiple fragment parents
jackpope 3b0e2b2
Add basic order preservation test
jackpope 76a1058
Dont store children on fragment instance, calculate at time of operation
jackpope 8683fa3
Handle Activity mode switch
jackpope b1c8f82
clean up
jackpope 0b658a8
Fix traversal order, remove focus mocks
jackpope b928cd3
Set stateNode in commit phase
jackpope 62f1619
Refactor fragment parent traversal to avoid allocations
jackpope cd64b20
Avoid allocations while traversing host children
jackpope 1a507ff
Keep fiber reference up to date
jackpope 5ad4e55
Fix event listener untracking
jackpope 4eab01b
Track new nodes in fragment instances from host placement flow
jackpope 0a2d423
Update test assertion
jackpope bb9e7f0
Remove config references from reconciler, detach refs, cleanup
jackpope ed883ab
Address additional feedback
jackpope f69d0c0
Unify getHostParentFiber and commitFragmentInstanceInsertionEffects l…
jackpope 33d65ee
Fix types
jackpope b46ae58
Remove ref flag check in reappearLayoutEffects
jackpope File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.