Skip to content

Don't auto-start browser in SSR fixtures #32652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2025
Merged

Don't auto-start browser in SSR fixtures #32652

merged 1 commit into from
Mar 17, 2025

Conversation

sebmarkbage
Copy link
Collaborator

I end up restarting these a lot and it's annoying to have it open another tab each time.

The flight fixture already doesn't auto-start.

@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Mar 17, 2025
rickhanlonii
rickhanlonii approved these changes Mar 17, 2025
View reviewed changes
Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes thank you so annoying

@react-sizebot
Copy link

Comparing: 9fde224...5b6eff8

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 517.29 kB 517.29 kB = 92.26 kB 92.26 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 605.66 kB 605.66 kB = 107.45 kB 107.45 kB
facebook-www/ReactDOM-prod.classic.js = 652.02 kB 652.02 kB = 114.84 kB 114.84 kB
facebook-www/ReactDOM-prod.modern.js = 642.30 kB 642.30 kB = 113.26 kB 113.26 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 5b6eff8

@sebmarkbage sebmarkbage merged commit 0237295 into facebook:main Mar 17, 2025
196 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 17, 2025
@sebmarkbage
Don't auto-start browser in SSR fixtures (#32652)
f8c51fc 
I end up restarting these a lot and it's annoying to have it open
another tab each time.

The flight fixture already doesn't auto-start.

DiffTrain build for [0237295](0237295)
@vercel-release-bot vercel-release-bot mentioned this pull request Mar 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickhanlonii rickhanlonii rickhanlonii approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sebmarkbage @react-sizebot @rickhanlonii @facebook-github-bot