Skip to content

[ci] Warm cache #32685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2025
Merged

[ci] Warm cache #32685

merged 1 commit into from
Mar 20, 2025
+20 −0

Conversation

poteto
Copy link
Member

@poteto poteto commented Mar 20, 2025 •
edited
Loading

Try restoring from old caches as a base to speed up the case where node_modules needs updating.

Stack created with Sapling. Best reviewed with ReviewStack.

@poteto poteto mentioned this pull request Mar 20, 2025
Merged
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Mar 20, 2025
@poteto
[ci] Warm cache
51e5e74 
Try restoring from old caches as a base to speed up the case where node_modules needs updating.
@poteto poteto changed the title [ci] Early exit and warm cache [ci] Warm cache Mar 20, 2025
@react-sizebot
Copy link

Comparing: a4f9bd5...51e5e74

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 517.29 kB 517.29 kB = 92.26 kB 92.26 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 617.58 kB 617.58 kB = 109.52 kB 109.52 kB
facebook-www/ReactDOM-prod.classic.js = 653.67 kB 653.67 kB = 115.18 kB 115.18 kB
facebook-www/ReactDOM-prod.modern.js = 643.95 kB 643.95 kB = 113.59 kB 113.59 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 51e5e74

@poteto poteto merged commit 3bcf8c2 into main Mar 20, 2025
178 checks passed
@poteto poteto deleted the pr32685 branch March 20, 2025 16:21
poteto added a commit that referenced this pull request Mar 20, 2025
@poteto
[ci] Fail on cache miss (#32686)
87d7e4c 
Since we use a centralized cache we should fail subsequent steps if the
child jobs are unable to restore the cache from the first 2 jobs.

Also fix some incorrect hashes used for the fixture tests.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32686).
* __->__ #32686
* #32685
This was referenced Mar 21, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@poteto @react-sizebot