Skip to content

Conversation

poteto
Copy link
Member

@poteto poteto commented Mar 21, 2025

Turns out we need permissions to write to contents after all.

Stack created with Sapling. Best reviewed with ReviewStack.

Turns out we need permissions to write to `contents` after all.
@react-sizebot
Copy link

Comparing: 156f0ec...e0aa150

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 515.14 kB 515.14 kB = 91.74 kB 91.74 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 615.53 kB 615.53 kB = 108.89 kB 108.89 kB
facebook-www/ReactDOM-prod.classic.js = 651.48 kB 651.48 kB = 114.89 kB 114.89 kB
facebook-www/ReactDOM-prod.modern.js = 641.76 kB 641.76 kB = 113.31 kB 113.31 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against e0aa150

@poteto poteto merged commit de4aad5 into main Mar 21, 2025
241 checks passed
@poteto poteto deleted the pr32710 branch March 21, 2025 22:01
github-actions bot pushed a commit that referenced this pull request Mar 21, 2025
Turns out we need permissions to write to `contents` after all.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32710).
* #32711
* __->__ #32710

DiffTrain build for [de4aad5](de4aad5)
github-actions bot pushed a commit that referenced this pull request Mar 21, 2025
Turns out we need permissions to write to `contents` after all.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32710).
* #32711
* __->__ #32710

DiffTrain build for [de4aad5](de4aad5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants