Allow fragment refs to attempt focus/focusLast on nested host children #33058
+88
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackpope
force-pushed
the
fragment-refs-deep-focus
branch
from
fe51ced to
4958839
Compare
|
Comparing: e5a8de8...0daf77b Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
jackpope
force-pushed
the
fragment-refs-deep-focus
branch
from
4958839 to
bc5f128
Compare
jackpope
force-pushed
the
fragment-refs-deep-focus
branch
from
bc5f128 to
0daf77b
Compare
jbrown215
approved these changes
May 7, 2025
There was a problem hiding this comment.
@jackpope and I discussed the tradeoff of looking through top-level host elements to expose focus and decided that the feature is more useful if we expose this capability.
That would mean that this is a semantically meaningful change:
const ref = useRef(null);
return (
<div ref={ref}>
<a />
</div>
);
// --> calling .focus will now focus the anchor element
const ref = useRef(null);
return (
<React.Fragment ref={ref}>
<div>
<a />
</div>
<React.Fragment/>
);
github-actions bot
pushed a commit
that referenced
this pull request
May 7, 2025
#33058) This enables `focus` and `focusLast` methods on FragmentInstances to search nested host components, depth first. Attempts focus on each child and bails if one is successful. Previously, only the first level of host children would attempt focus. Now if we have an example like ``` component MenuItem() { return (<div><a>{...}</a></div>) } component Menu() { return <Fragment>{items.map(i => <MenuItem i={i} />)}</Fragment> } ``` We can target focus on the first or last a tag, rather than checking each wrapping div and then noop. DiffTrain build for [4206fe4](4206fe4)
github-actions bot
pushed a commit
that referenced
this pull request
May 7, 2025
#33058) This enables `focus` and `focusLast` methods on FragmentInstances to search nested host components, depth first. Attempts focus on each child and bails if one is successful. Previously, only the first level of host children would attempt focus. Now if we have an example like ``` component MenuItem() { return (<div><a>{...}</a></div>) } component Menu() { return <Fragment>{items.map(i => <MenuItem i={i} />)}</Fragment> } ``` We can target focus on the first or last a tag, rather than checking each wrapping div and then noop. DiffTrain build for [4206fe4](4206fe4)
This was referenced May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables
focusandfocusLastmethods on FragmentInstances to search nested host components, depth first. Attempts focus on each child and bails if one is successful. Previously, only the first level of host children would attempt focus.Now if we have an example like
We can target focus on the first or last a tag, rather than checking each wrapping div and then noop.