[Flight] Clarify that location field is a FunctionLocation not a CallSite #33141
+23
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
sebmarkbage
commented
May 7, 2025
| string, // function name | ||
| string, // file name TODO: model nested eval locations as nested arrays | ||
| number, // enclosing line number | ||
| number, // enclosing column number |
There was a problem hiding this comment.
Like it's not the enclosing of the function location but more like what enclosing means in the context of a callsite. I.e. function location.
eps1lon
approved these changes
May 7, 2025
|
Comparing: 4206fe4...fbd7352 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
|
FunctionDeclaration would also work. That might be confused with the AST nodes though. Separate name from "CallSite" definitely makes sen |
github-actions bot
pushed a commit
that referenced
this pull request
May 7, 2025
…Site (#33141) Follow up to #33136. This clarifies in the types where the conversion happens from a CallSite which we use to simulate getting the enclosing line/col to a FunctionLocation which doesn't represent a CallSite but actually just the function which only has an enclosing line/col. DiffTrain build for [a437c99](a437c99)
This was referenced May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #33136.
This clarifies in the types where the conversion happens from a CallSite which we use to simulate getting the enclosing line/col to a FunctionLocation which doesn't represent a CallSite but actually just the function which only has an enclosing line/col.