Skip to content

Conversation

sebmarkbage
Copy link
Collaborator

There seems to be some bugs still to work out in Chrome. See #33187.

Additionally, since you can't really rely on this function existing across browsers, it's hard to depend on its behavior anyway. In fact, you now have a source of inconsistent behaviors across browsers to deal with.

Ideally it would also be more widely spread in fake DOM implementations like JSDOM so that we can use it unconditionally. #33177.

We still want to enable this since it's a great feature but maybe not until it's more widely available cross-browsers with fewer bugs.

@sebmarkbage sebmarkbage requested review from sophiebits and eps1lon May 23, 2025 14:47
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label May 23, 2025
@react-sizebot
Copy link

Comparing: 99efc62...8b6ead1

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 529.83 kB 529.83 kB = 93.52 kB 93.52 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 651.62 kB 650.93 kB = 114.80 kB 114.65 kB
facebook-www/ReactDOM-prod.classic.js = 675.87 kB 675.87 kB = 118.93 kB 118.93 kB
facebook-www/ReactDOM-prod.modern.js = 666.15 kB 666.15 kB = 117.31 kB 117.31 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 8b6ead1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants